New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @property setters for Cookie properties. #176

Merged
merged 1 commit into from Feb 6, 2013

Conversation

Projects
None yet
2 participants
@Abscissa

Abscissa commented Feb 6, 2013

It's kinda weird to have idiomatic D @Property getters for members of class Cookie like isSecure, path, maxAge, etc, but then for setting them only offer Java-like setSecure, setPath, setMaxAge, etc.

I realize the set*() funcs are to allow chaining, and that's fine, but I'm not sure that should preclude inclusion of idiomatic setters.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 6, 2013

Member

Definitely! I think that code was written by a D newcomer at the time.

Member

s-ludwig commented Feb 6, 2013

Definitely! I think that code was written by a D newcomer at the time.

s-ludwig added a commit that referenced this pull request Feb 6, 2013

@s-ludwig s-ludwig merged commit 53ef454 into vibe-d:master Feb 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment