New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-up TTL when opening an existing session #1777

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
2 participants
@schveiguy
Contributor

schveiguy commented Jun 9, 2017

When reading the description of expirationTime, it says "The duration without access after which a session expires." To me, this means if you continue to "access" the session, it resets the duration. However, in the implementation, it only sets the TTL once, when the session is created. This means that accessing it does not re-up the timeout.

This fixes that, so now every time you open the session, it also resets the timeout. This is what I would expect session expiration to mean.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jun 9, 2017

Member

Definitely the right behavior!

Member

s-ludwig commented Jun 9, 2017

Definitely the right behavior!

@s-ludwig s-ludwig merged commit 1677990 into vibe-d:master Jun 9, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schveiguy schveiguy deleted the schveiguy:patch-1 branch Jun 10, 2017

s-ludwig added a commit that referenced this pull request Sep 2, 2017

Merge pull request #1777 from schveiguy/patch-1
Re-up TTL when opening an existing session
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment