New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit thread destruction code in the libasync driver. #1837

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
3 participants
@s-ludwig
Member

s-ludwig commented Jul 13, 2017

See the discussion in #1835. Libasync now uses the default thread pool of std.parallelism, which is shut down automatically.

Remove explicit thread destruction code in the libasync driver.
See the discussion in #1835. Libasync now uses the default thread pool of std.parallelism, which is shut down automatically.

@s-ludwig s-ludwig added the auto-merge label Jul 13, 2017

@dlang-bot dlang-bot merged commit e79c871 into master Jul 13, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@wilzbach

This comment has been minimized.

Show comment
Hide comment
@wilzbach

wilzbach Jul 13, 2017

Contributor

Wow that was a quick resolution - could you maybe release a new tag, s.t. these changes are propagated to the Project-Tester? Thanks!

Contributor

wilzbach commented Jul 13, 2017

Wow that was a quick resolution - could you maybe release a new tag, s.t. these changes are propagated to the Project-Tester? Thanks!

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 13, 2017

Member

Let's wait with this until #1838 is merged, too.

Member

s-ludwig commented Jul 13, 2017

Let's wait with this until #1838 is merged, too.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 14, 2017

Member

0.8.1-alpha.1 is now tagged and also available on code.dlang.org.

Member

s-ludwig commented Jul 14, 2017

0.8.1-alpha.1 is now tagged and also available on code.dlang.org.

@wilzbach

This comment has been minimized.

Show comment
Hide comment
@wilzbach

wilzbach Jul 15, 2017

Contributor

0.8.1-alpha.1 is now tagged and also available on code.dlang.org.

Thanks a lot. I will try to keep an eye on the Project-Tester to check whether this solved our problems.

Contributor

wilzbach commented Jul 15, 2017

0.8.1-alpha.1 is now tagged and also available on code.dlang.org.

Thanks a lot. I will try to keep an eye on the Project-Tester to check whether this solved our problems.

@s-ludwig s-ludwig deleted the remove_libasync_destroy_threads branch Jul 16, 2017

s-ludwig added a commit that referenced this pull request Sep 2, 2017

Merge pull request #1837 from rejectedsoftware/remove_libasync_destro…
…y_threads

Remove explicit thread destruction code in the libasync driver.
merged-on-behalf-of: Sönke Ludwig <s-ludwig@users.noreply.github.com>
Conflicts:
	source/vibe/core/drivers/libasync.d

s-ludwig added a commit that referenced this pull request Sep 2, 2017

Merge pull request #1837 from rejectedsoftware/remove_libasync_destro…
…y_threads

Remove explicit thread destruction code in the libasync driver.
merged-on-behalf-of: Sönke Ludwig <s-ludwig@users.noreply.github.com>
Conflicts:
	source/vibe/core/drivers/libasync.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment