New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebSocket ping logic. Fixes #1471. #1848

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
1 participant
@s-ludwig
Member

s-ludwig commented Jul 17, 2017

  • Fixes server initiated PINGs to be properly masked
  • Fixes the detection logic for matching PONG messages
  • Uses send() to send control messages instead of manually assembling frames
  • Streamlines processing of control messages
Fix WebSocket ping logic. Fixes #1471.
- Fixes server initiated PINGs to be properly masked
- Fixes the detection logic for matching PONG messages
- Uses send() to send control messages instead of manually assembling frames
- Streamlines processing of control messages

@s-ludwig s-ludwig merged commit e3d6217 into master Jul 17, 2017

5 of 6 checks passed

codecov/patch 0% of diff hit (target 2.157%)
Details
codecov/project 2.163% (+0.006%) compared to f960427
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@s-ludwig s-ludwig deleted the issue1471_websocket_ping branch Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment