New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added web interface language() property #1860

Merged
merged 1 commit into from Jul 19, 2017

Conversation

Projects
None yet
3 participants
@WebFreak001
Contributor

WebFreak001 commented Jul 19, 2017

Because s_requestContext was private you couldn't really get the language that was chosen without including the request as argument and then calling the translation context's determine language function.

@s-ludwig s-ludwig added the auto-merge label Jul 19, 2017

@WebFreak001

This comment has been minimized.

Show comment
Hide comment
@WebFreak001

WebFreak001 Jul 19, 2017

Contributor

Test failed with Unable to connect to the remote server...

Contributor

WebFreak001 commented Jul 19, 2017

Test failed with Unable to connect to the remote server...

@wilzbach

This comment has been minimized.

Show comment
Hide comment
@wilzbach

wilzbach Jul 19, 2017

Contributor

That just means that code.dlang.org is down. That happens fairly often for a short time - nothing to worry about.

Contributor

wilzbach commented Jul 19, 2017

That just means that code.dlang.org is down. That happens fairly often for a short time - nothing to worry about.

@wilzbach

This comment has been minimized.

Show comment
Hide comment
@wilzbach

wilzbach Jul 19, 2017

Contributor

nothing to worry about.

Except for auto-merge of course

Contributor

wilzbach commented Jul 19, 2017

nothing to worry about.

Except for auto-merge of course

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 19, 2017

Member

BTW, I was trying work on the exception issue tonight, but made matters worse for a while. It seems to be back to normal now, but I still get the intermittent failures. I'll have to improve the debug facilities there.

Member

s-ludwig commented Jul 19, 2017

BTW, I was trying work on the exception issue tonight, but made matters worse for a while. It seems to be back to normal now, but I still get the intermittent failures. I'll have to improve the debug facilities there.

@s-ludwig s-ludwig merged commit 72885d3 into vibe-d:master Jul 19, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@WebFreak001

This comment has been minimized.

Show comment
Hide comment
@WebFreak001

WebFreak001 Jul 19, 2017

Contributor

@wilzbach does it crash or can't it handle the requests because there are too many requests or is it the package update mechanism doing that?

Contributor

WebFreak001 commented Jul 19, 2017

@wilzbach does it crash or can't it handle the requests because there are too many requests or is it the package update mechanism doing that?

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 19, 2017

Member

@WebFreak001 he reverse proxy that is in front of the registry process (also implemented with vibe.d) sometimes hangs in exception unwinding code. LDC first seemed to fix that, but it only lasted for a few hours. I'm looking for possible workarounds.

Member

s-ludwig commented Jul 19, 2017

@WebFreak001 he reverse proxy that is in front of the registry process (also implemented with vibe.d) sometimes hangs in exception unwinding code. LDC first seemed to fix that, but it only lasted for a few hours. I'm looking for possible workarounds.

@WebFreak001 WebFreak001 deleted the WebFreak001:web-language branch Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment