New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #967 & made MongoCursor.limit/skip safe #1871

Merged
merged 1 commit into from Aug 11, 2017

Conversation

Projects
None yet
3 participants
@WebFreak001
Contributor

WebFreak001 commented Jul 25, 2017

m_currentDoc was relative to the chunk start and not relative to the document start. I dislike the current mongodb testing system by manually calling these test() functions inside unittests when changing something, that basically destroys the whole reason of automated tests. Can't you install mongodb on the travis & appveyor test servers?

@wilzbach

This comment has been minimized.

Show comment
Hide comment
@wilzbach

wilzbach Jul 25, 2017

Contributor

Can't you install mongodb on the travis & appveyor test servers?

https://github.com/rejectedsoftware/vibe.d/blob/master/.travis.yml

I think the point was that

  • not everyone running dub tests has mongo installed and running
  • DB tests need fixtures and cleanups, which you would have to add to the unittest as well.
Contributor

wilzbach commented Jul 25, 2017

Can't you install mongodb on the travis & appveyor test servers?

https://github.com/rejectedsoftware/vibe.d/blob/master/.travis.yml

I think the point was that

  • not everyone running dub tests has mongo installed and running
  • DB tests need fixtures and cleanups, which you would have to add to the unittest as well.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 10, 2017

Member

The test() functions in unit tests are actually never invoked at all. Those unit tests just serve as documentation examples that get syntax checked in the unittest build. The actual tests happen as high level tests in the tests/ folder.

Member

s-ludwig commented Aug 10, 2017

The test() functions in unit tests are actually never invoked at all. Those unit tests just serve as documentation examples that get syntax checked in the unittest build. The actual tests happen as high level tests in the tests/ folder.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 11, 2017

Member

I'll move the test to the tests/ folder after merge. The fix looks good!

Member

s-ludwig commented Aug 11, 2017

I'll move the test to the tests/ folder after merge. The fix looks good!

@s-ludwig s-ludwig merged commit 2494156 into vibe-d:master Aug 11, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 5cdd12e...2503f14
Details
codecov/project 2.165% remains the same compared to 5cdd12e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

s-ludwig added a commit that referenced this pull request Sep 2, 2017

Merge pull request #1871 from WebFreak001/fix-967
Fix #967 & made MongoCursor.limit/skip safe

s-ludwig added a commit that referenced this pull request Sep 2, 2017

Merge pull request #1871 from WebFreak001/fix-967
Fix #967 & made MongoCursor.limit/skip safe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment