New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handleHTTPConnection public #1929

Merged
merged 4 commits into from Sep 15, 2017

Conversation

Projects
None yet
2 participants
@s-ludwig
Member

s-ludwig commented Sep 14, 2017

This allows accepting incoming HTTP connections on a custom transport, such as a pre-established TCP connection, or a USDS socket.

s-ludwig added some commits Sep 14, 2017

Move HTTP contexts into the HTTPListenInfo class.
Reduces overhead and improves information locality. This also means that no globals are accessed anymore inside of handleHTTPConntection.
Bundle all virtual host logic in HTTPListenInfo.
This will enable abstracting the connection handler logic from the management of HTTP listeners, so that handleHTTPConnection can be made public.
Make handleHTTPConnection and HTTPServerContext public.
HTTPListenInfo was renamed to HTTPServerContext in the public API.

@s-ludwig s-ludwig added the auto-merge label Sep 15, 2017

@dlang-bot dlang-bot merged commit 2fea3a4 into master Sep 15, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@s-ludwig s-ludwig referenced this pull request Sep 15, 2017

Closed

Http listener #1492

@s-ludwig s-ludwig deleted the custom_http_transport branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment