New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vibe.web.web.redirect similar to HTTPServerResponse.redirect #1948

Merged
merged 1 commit into from Apr 2, 2018

Conversation

Projects
None yet
3 participants
@wilzbach
Contributor

wilzbach commented Oct 10, 2017

Provide the same API as HTTPServerResponse.redirect

@@ -378,6 +378,12 @@ void redirect(string url)
ctx.res.redirect(fullurl);

This comment has been minimized.

@thaven

thaven Oct 11, 2017

Contributor

I suppose status should be passed here....

This comment has been minimized.

@s-ludwig

s-ludwig Oct 14, 2017

Member

And found instead of Found ("deprecated")

/// ditto
void redirect(URL url, int status = HTTPStatus.Found)
@safe {
redirect(url.toString);

This comment has been minimized.

@thaven

thaven Oct 11, 2017

Contributor

... and here.

@wilzbach

This comment has been minimized.

Contributor

wilzbach commented Nov 30, 2017

Finally found time to rebase this PR - sorry for the forgetting to pass on status. Silly :S

@wilzbach wilzbach removed the needs input label Apr 2, 2018

@wilzbach

This comment has been minimized.

Contributor

wilzbach commented Apr 2, 2018

Ping @s-ludwig - this has been ready for five months now ;-)

@s-ludwig s-ludwig merged commit b9985f4 into vibe-d:master Apr 2, 2018

1 of 4 checks passed

codecov/patch CI failed.
Details
codecov/project CI failed.
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment