New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow names with only one char in adjustMethodStyle.. #195

Merged
merged 1 commit into from Mar 15, 2013

Conversation

Projects
None yet
3 participants
@HowToMeetLadies
Contributor

HowToMeetLadies commented Mar 14, 2013

Just a small fix to adjustMethodStyle.

Testcase:

interface ITest { Json getQ(Json q); }
class Test : ITest { Json getQ(Json q) { return q; } }
// REST route: POST / ["q"]
@mihails-strasuns

This comment has been minimized.

Show comment
Hide comment
@mihails-strasuns

mihails-strasuns Mar 14, 2013

Contributor

Adding unit tests for changed functions is usually a good idea, especially if they do lack them currently. If we all will do it, it will help vibe.d greatly in the long run :)

Contributor

mihails-strasuns commented Mar 14, 2013

Adding unit tests for changed functions is usually a good idea, especially if they do lack them currently. If we all will do it, it will help vibe.d greatly in the long run :)

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 15, 2013

Member

I'll add some unit tests after pulling, it's indeed a good candidate.

Member

s-ludwig commented Mar 15, 2013

I'll add some unit tests after pulling, it's indeed a good candidate.

s-ludwig added a commit that referenced this pull request Mar 15, 2013

Merge pull request #195 from HowToMeetLadies/patch-1
Allow names with only one char in adjustMethodStyle..

@s-ludwig s-ludwig merged commit f5a7f26 into vibe-d:master Mar 15, 2013

s-ludwig added a commit that referenced this pull request Mar 15, 2013

Add unit tests for adjustMethodStyle and support acronyms in names.
Converting getHTMLEntity is now translated to get_html_entity instead of get_h_t_m_l_entity.
See also #195.

@HowToMeetLadies HowToMeetLadies deleted the HowToMeetLadies:patch-1 branch Mar 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment