New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy CONNECT request handling. #1973

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@s-ludwig
Member

s-ludwig commented Nov 6, 2017

There were two issues:

  • The destination resource ("host:port") was not parsed correctly
  • The response header was missing

See #1893.

Fix proxy CONNECT request handling.
There were two issues:
- The destination resource ("host:port") was not parsed correctly
- The response header was missing

See #1893.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Nov 6, 2017

Member

There is still an issue in the closing procedure where an assertion in the libevent driver is triggered, but this appears to be specific to the libevent driver. Using vibe-core does not show a similar issue.

Member

s-ludwig commented Nov 6, 2017

There is still an issue in the closing procedure where an assertion in the libevent driver is triggered, but this appears to be specific to the libevent driver. Using vibe-core does not show a similar issue.

@s-ludwig s-ludwig added the auto-merge label Nov 6, 2017

@dlang-bot dlang-bot merged commit 57091ea into master Nov 6, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@s-ludwig s-ludwig deleted the fix_proxy_connect branch Nov 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment