New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RedisHash!int.opIndexOpAssign #2013

Merged
merged 2 commits into from Dec 21, 2017

Conversation

Projects
None yet
2 participants
@Geoffrey-A
Contributor

Geoffrey-A commented Dec 20, 2017

Hello,

A fix as per title.

Thank you very much for dub and vibe.d!

Best regards,
Geoffrey

Geoffrey-A added some commits Dec 20, 2017

Fix RedisHash.opIndexOpAssign.
The snippet `m_db.getAsHash!int("bank_accounts")["bob"] += 100;` failed with the following error:
../../.dub/packages/vibe-d-0.8.2/vibe-d/redis/vibe/db/redis/types.d(392,84): Error: none of the overloads of 'hincr' are callable using argument types (string, string, string), candidates are:
../../.dub/packages/vibe-d-0.8.2/vibe-d/redis/vibe/db/redis/redis.d(318,7):        vibe.db.redis.redis.RedisDatabase.hincr(string key, string field, long value = 1L)
../../.dub/packages/vibe-d-0.8.2/vibe-d/redis/vibe/db/redis/redis.d(320,7):        vibe.db.redis.redis.RedisDatabase.hincr(string key, string field, double value)
@s-ludwig

This comment has been minimized.

Member

s-ludwig commented Dec 21, 2017

Thanks!

@s-ludwig s-ludwig merged commit 1909cf3 into vibe-d:master Dec 21, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 9896eda...20389d6
Details
codecov/project 62.978% (+0.6%) compared to 9896eda
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Geoffrey-A Geoffrey-A deleted the Geoffrey-A:fix/RedisHash!int.opIndexOpAssign branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment