Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix: forward RedisValue methods hidden in redis types by overloads #2026
All supported redis values now work as per the test below:
auto db = connectRedis("127.0.0.1").getDatabase(0); db.getAsList("test_list").remove(); db.getAsSet("test_set").remove(); db.getAsZSet("test_zset").remove(); db.getAsHash("test_hash").remove(); db.getAsString("test_string").remove();
Seeing it was not merged after a few days, I added a few commits. They fix the forwarding of the hidden RedisValue methods in the redis types which were hiding them:
I also checked there was no other method from RedisValue that was hidden by any redis type.
Since I committed, the dlang bot removed the auto-merge tag.
Please allow me a few questions:
The "auto-merge" is supposed to provide a "shoot and forget" mode, where you don't have to wait until all CI checks complete. Unfortunately there are currently still too many network related failures, so that this often fails and then sits in the queue unnoticed. But this will hopefully be sorted out in a while.
Fortunately I can merge immediately now, since the tests have already finished...