New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly parse the host part of file URLs. Fixes #2048. #2049

Merged
merged 1 commit into from Jan 28, 2018

Conversation

Projects
None yet
2 participants
@s-ludwig
Member

s-ludwig commented Jan 26, 2018

No description provided.

@wilzbach

https://github.com/vibe-d/vibe.d/pull/2049/files?w=1 makes it a lot easier to review :)

@wilzbach wilzbach added the auto-merge label Jan 28, 2018

@s-ludwig

This comment has been minimized.

Member

s-ludwig commented Jan 28, 2018

Nice, I didn't know that that also ignores indentation changes.

(merging manually due to the version check error and will tag a new alpha in a moment)

@s-ludwig s-ludwig merged commit cd22253 into master Jan 28, 2018

1 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@s-ludwig s-ludwig deleted the issue_2048_file_url_host branch Jan 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment