Fix deprecations: use atomicOp in examples/bench-http-request #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
PetarKirov
reviewed
Feb 5, 2018
| readOption("k", &g_maxKeepAliveRequests, "Maximum number of keep-alive requests for each connection"); | ||
| readOption("c", cast(long*) &g_concurrency, "The maximum number of concurrent requests"); | ||
| readOption("d", cast(long*) &g_requestDelay, "Artificial request delay in milliseconds"); | ||
| readOption("k", cast(long*) &g_maxKeepAliveRequests, "Maximum number of keep-alive requests for each connection"); |
There was a problem hiding this comment.
A better design would be to make those variables immutable and to set them from a shared static constructor.
There was a problem hiding this comment.
but that would require duplicating these three variables, wouldn't it?
(then I could use atomicStore as well)
wilzbach
changed the title
|
Agree that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another deprecation removed.
Note that
std.getoptdoesn't supportshared.See also: dlang/dmd#7816