New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce hash calculations in json opIndex #2135

Merged
merged 1 commit into from Mar 30, 2018

Conversation

Projects
None yet
2 participants
@Boris-Barboris
Contributor

Boris-Barboris commented Mar 29, 2018

This small fix improves efficiency of Json object field assignment by reusing an AA bin pointer.

@Boris-Barboris

This comment has been minimized.

Contributor

Boris-Barboris commented Mar 30, 2018

@s-ludwig all passed.
Btw, do you mind such poking?

@s-ludwig

This comment has been minimized.

Member

s-ludwig commented Mar 30, 2018

Thanks! No, don't mind at all, as I frequently miss things in the stream of GitHub events.

@s-ludwig s-ludwig merged commit 6aca8c9 into vibe-d:master Mar 30, 2018

3 checks passed

codecov/patch 100% of diff hit (target 58.546%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Boris-Barboris Boris-Barboris deleted the Boris-Barboris:json_opindex branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment