New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB: adds max pool size setting #2145

Merged
merged 2 commits into from Apr 26, 2018

Conversation

Projects
None yet
2 participants
@denizzzka
Contributor

denizzzka commented Apr 11, 2018

No description provided.

@@ -321,6 +321,7 @@ class MongoClientSettings
string username;
string digest;
uint max_connections = uint.max;

This comment has been minimized.

@denizzzka

denizzzka Apr 11, 2018

Contributor

It is because uint.max is default value for ConnectionPool ctor argument max_concurrent

@denizzzka

This comment has been minimized.

Contributor

denizzzka commented Apr 12, 2018

(Isn't know why codecove fails)

@s-ludwig

This comment has been minimized.

Member

s-ludwig commented Apr 13, 2018

MongoClientSettings.max_connections should be named maxConnections, otherwise looks good to merge. The CodeCov error is hard to fix, because declaration lines are counted as code that needs to be covered, which obviously is hard to do.

@s-ludwig s-ludwig added the auto-merge label Apr 13, 2018

@s-ludwig s-ludwig merged commit b06f50e into vibe-d:master Apr 26, 2018

2 of 3 checks passed

codecov/patch 50% of diff hit (target 58.787%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment