New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization of const/mutable and wide character strings #2151

Merged
merged 2 commits into from May 4, 2018

Conversation

Projects
None yet
2 participants
@s-ludwig
Member

s-ludwig commented May 3, 2018

Fixes #2150.

@Geod24

This comment has been minimized.

Contributor

Geod24 commented May 3, 2018

data/vibe/data/json.d(2269,11): Error: none of the overloads of put are callable using argument types (const(char)[]), candidates are:
utils/vibe/internal/rangeutil.d(11,7):        vibe.internal.rangeutil.RangeCounter.put(char ch)
utils/vibe/internal/rangeutil.d(12,7):        vibe.internal.rangeutil.RangeCounter.put(string str)
utils/vibe/internal/rangeutil.d(13,7):        vibe.internal.rangeutil.RangeCounter.put(dchar ch)
utils/vibe/internal/rangeutil.d(14,7):        vibe.internal.rangeutil.RangeCounter.put(dstring str)
data/vibe/data/json.d(2111,14): Error: template instance `vibe.data.json.jsonEscape!(false, RangeCounter)` error instantiating

Looks like a good candidate for const(char)[] (and const(dchar)[])

@s-ludwig s-ludwig merged commit 14db8a2 into master May 4, 2018

3 checks passed

codecov/patch 97.058% of diff hit (target 58.895%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@s-ludwig s-ludwig deleted the issue_2150_json_const_string_serialization branch May 4, 2018

@Geod24

This comment has been minimized.

Contributor

Geod24 commented May 4, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment