Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL default port getter #2176

Merged
merged 1 commit into from Jul 6, 2018
Merged

Fix URL default port getter #2176

merged 1 commit into from Jul 6, 2018

Conversation

@gedaiu
Copy link
Contributor

@gedaiu gedaiu commented Jun 23, 2018

Getting the URL port, when it's not specified, it returns 0. This issue should fix this.

@UplinkCoder
Copy link
Contributor

@UplinkCoder UplinkCoder commented Jun 24, 2018

I'd say !port is clearer and shorter but otherwise LGTM

Loading

@gedaiu
Copy link
Contributor Author

@gedaiu gedaiu commented Jun 24, 2018

Loading

@wilzbach wilzbach merged commit c8bdb41 into vibe-d:master Jul 6, 2018
3 checks passed
Loading
@gedaiu gedaiu deleted the fix-url-port branch Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants