Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL default port getter #2176

Merged
merged 1 commit into from Jul 6, 2018

Conversation

Projects
None yet
3 participants
@gedaiu
Copy link
Contributor

commented Jun 23, 2018

Getting the URL port, when it's not specified, it returns 0. This issue should fix this.

@UplinkCoder

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2018

I'd say !port is clearer and shorter but otherwise LGTM

@gedaiu gedaiu force-pushed the gedaiu:fix-url-port branch from ecfd024 to 5e48994 Jun 24, 2018

@gedaiu gedaiu force-pushed the gedaiu:fix-url-port branch from 5e48994 to 8311e3d Jun 24, 2018

@gedaiu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2018

@wilzbach wilzbach merged commit c8bdb41 into vibe-d:master Jul 6, 2018

3 checks passed

codecov/patch 100% of diff hit (target 59.149%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gedaiu gedaiu deleted the gedaiu:fix-url-port branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.