Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RestInterfaceSettings.dup() for errorHandler callback #2197

Merged
merged 2 commits into from Aug 14, 2018

Conversation

Projects
None yet
2 participants
@vitalka200
Copy link
Contributor

commented Aug 9, 2018

Added missing fields copy in RestInterfaceSettings.dup().

Without this, setting errorHandler callback will not work because
of this in module vibe.web.internal.rest.common:L118

this.settings = settings ? settings.dup : new RestInterfaceSettings;

vitalka200 added some commits Aug 9, 2018

Added missing fields copy for RestInterfaceSettings
- Added copy for .errorHandler
- Added copy for .httpClientSettings
@vitalka200

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

@s-ludwig @wilzbach When it can be merged?

@wilzbach wilzbach merged commit c350d39 into vibe-d:master Aug 14, 2018

3 checks passed

codecov/patch 22.222% of diff hit (target 59.359%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.