Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RestInterfaceSettings.dup() for errorHandler callback #2197

Merged
merged 2 commits into from Aug 14, 2018

Conversation

@vitalka200
Copy link
Contributor

@vitalka200 vitalka200 commented Aug 9, 2018

Added missing fields copy in RestInterfaceSettings.dup().

Without this, setting errorHandler callback will not work because
of this in module vibe.web.internal.rest.common:L118

this.settings = settings ? settings.dup : new RestInterfaceSettings;
vitalka200 added 2 commits Aug 9, 2018
- Added copy for .errorHandler
- Added copy for .httpClientSettings
@vitalka200
Copy link
Contributor Author

@vitalka200 vitalka200 commented Aug 9, 2018

@s-ludwig @wilzbach When it can be merged?

@wilzbach wilzbach merged commit c350d39 into vibe-d:master Aug 14, 2018
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants