Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenSSL 1.1.1 by using new APIs #2226

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@WebFreak001
Copy link
Contributor

commented Oct 26, 2018

Use new BIO methods
more error handling
Also changes minimum protocol version to new API
Split the error handling API to be more usable
Fix IO error message
fix #2214

Use new BIO methods, more error handling
Also changes minimum protocol version to new API
Split the error handling API to be more usable
Fix IO error message
fix #2214
@WebFreak001

This comment has been minimized.

Copy link
Contributor Author

commented Oct 26, 2018

Couldn't test OpenSSL 1.0.0 locally because of linking errors which existed before the PR already (no, the libs hack doesn't fix it because then it segfaults trying to mix 1.1.1 and 1.0.0)

@WebFreak001

This comment has been minimized.

Copy link
Contributor Author

commented Oct 28, 2018

ping @s-ludwig @wilzbach

fixes vibe.d on ArchLinux, Ubuntu 18.10 and other distros using OpenSSL 1.1.1

b.flags = 0;
b.ptr = null;
BIO_set_init(b, 0);
BIO_clear_flags(b, int.max);

This comment has been minimized.

Copy link
@s-ludwig

s-ludwig Nov 6, 2018

Member

Don't you mean -1 (or better ~0) here?

@s-ludwig

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

Looks fine to me. Since the CI tests pass, the 1.0.x branch should still be fine. I'd test for 1.1.0 after the merge and before tagging a new version.

@s-ludwig s-ludwig merged commit 7fdf59a into vibe-d:master Nov 7, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.