Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made WebParamAttribute public to allow rest introspection #2250

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
3 participants
@burner
Copy link
Contributor

commented Jan 10, 2019

I'm currently building a angular service generator.
This is done by introspecting rest interfaces.
To get the parameter names right, it needs to look at the UDAs, and more
specifically at WebParamAttribute.

ParameterKind origin;
/// Parameter name
/// Parameter name (Server side)

This comment has been minimized.

Copy link
@s-ludwig

s-ludwig Jan 11, 2019

Member

What about "function parameter name" to make this even more clear?

This comment has been minimized.

Copy link
@burner

burner Jan 12, 2019

Author Contributor

will do

This comment has been minimized.

Copy link
@burner

burner Jan 12, 2019

Author Contributor

@s-ludwig fixed

Made WebParamAttribute public to allow rest introspection
I'm currently building a angular service generator.
This is done by introspecting rest interfaces.
To get the parameter names right, it needs to look at the UDAs, and more
specifically at WebParamAttribute.

* Sönke remarks worked in

@burner burner force-pushed the burner:WebParamAttribute_public branch from 026b970 to 904a8c6 Jan 12, 2019

@s-ludwig s-ludwig added the auto-merge label Jan 12, 2019

@burner

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

@s-ludwig thank you

@dlang-bot dlang-bot merged commit 763a83a into vibe-d:master Jan 12, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 78b0bbe...904a8c6
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.