Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DNS cache #2257

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
2 participants
@marcioapm
Copy link
Contributor

commented Jan 31, 2019

Caching at this layer is not going to work, because we don't know the TTL.
Because of this cache, you might be in a situation where you try to connect to a host that is no longer there, or worse, you connect to a host that is not what you expected.

Remove DNS cache
Caching at this layer is not going to work, because we don't know the TTL.
Because of this cache, you might be in a situation where you try to connect to a host that is no longer there, or worse, you connect to a host that is not what you expected.
@marcioapm

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

Meanwhile, there is no work-around :(

@s-ludwig

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

Sounds okay, though. This task should be done by an external caching DNS proxy or to some wrapper around resolveHost instead.

@s-ludwig s-ludwig merged commit 39367c9 into vibe-d:master Feb 1, 2019

3 checks passed

codecov/patch Coverage not affected when comparing cb62d14...01c14c1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.