Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disconnection of cached ConnectionPool connections #2287

Merged
merged 7 commits into from Mar 29, 2019

Conversation

@s-ludwig
Copy link
Member

commented Mar 28, 2019

No description provided.

@s-ludwig s-ludwig force-pushed the connectionpool_disconnect branch from 15ab4d0 to da42058 Mar 28, 2019
@s-ludwig s-ludwig force-pushed the connectionpool_disconnect branch from da42058 to 8020736 Mar 29, 2019
@s-ludwig s-ludwig added the auto-merge label Mar 29, 2019
@s-ludwig s-ludwig force-pushed the connectionpool_disconnect branch from 8020736 to 4cf2598 Mar 29, 2019
s-ludwig added 7 commits Mar 28, 2019
Allows to disconnect all connections that are not currently in use. In particular, it allows to close all connections at shutdown to avoid leaking socket descriptors.

fixup remove logic
There was a case where previous errors propagated to the construction of a new TLS stream.
Disconnects any unused connections to the server.
@s-ludwig s-ludwig force-pushed the connectionpool_disconnect branch from 4cf2598 to 7acac03 Mar 29, 2019
@s-ludwig s-ludwig added the auto-merge label Mar 29, 2019
@dlang-bot dlang-bot merged commit 06ba331 into master Mar 29, 2019
3 checks passed
3 checks passed
codecov/patch 69.23% of diff hit (target 35.552%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@s-ludwig s-ludwig deleted the connectionpool_disconnect branch Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.