Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new cookie option: sameSiteStrict #2297

Merged
merged 1 commit into from Apr 26, 2019

Conversation

@wilzbach

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

Tested this and it can be used with #2299

settings.sessionOptions |= SessionOption.sameSiteStrict;

image

image

http/vibe/http/common.d Outdated Show resolved Hide resolved
http/vibe/http/common.d Outdated Show resolved Hide resolved
http/vibe/http/server.d Outdated Show resolved Hide resolved
@wilzbach wilzbach force-pushed the wilzbach:same-site-strict branch from 9e83bdb to dc9cad8 Apr 19, 2019
@wilzbach

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

Since this is the lowest API level, it would be nice to add a Cookie.SameSite enum with default, lax and strict, and a @Property void sameSite(SameSite).

Done.

I'd even argue to make this the default and provide an optional flag to switch back to the default behavior.

Done 👍

@s-ludwig s-ludwig merged commit 1f5b649 into vibe-d:master Apr 26, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codecov/patch 0% of diff hit (target 35.842%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.