Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to disable port and address reuse #2303

Merged
merged 3 commits into from May 19, 2019

Conversation

@rracariu
Copy link
Contributor

rracariu commented Apr 16, 2019

This integrates with recent event core reuseAddress flag.
It allows one to selectively disable those flags.
See vibe-d/vibe-core#150

@rracariu rracariu force-pushed the rracariu:patch-1 branch from d318407 to f5450c4 Apr 17, 2019
@wilzbach

This comment has been minimized.

Copy link
Member

wilzbach commented Apr 19, 2019

If it's the default, why not rename the options accordingly then: doNotReuseAddress (or sth. like that)

http/vibe/http/server.d Outdated Show resolved Hide resolved
@rracariu rracariu force-pushed the rracariu:patch-1 branch from f5450c4 to ae41fc7 Apr 21, 2019
@rracariu

This comment has been minimized.

Copy link
Contributor Author

rracariu commented Apr 21, 2019

If it's the default, why not rename the options accordingly then: doNotReuseAddress (or sth. like that)

Was looking to be consistent with reusePort and the TCP and Stream defines for the reuseAddress option.

@s-ludwig

This comment has been minimized.

Copy link
Member

s-ludwig commented Apr 23, 2019

I would propose to add a new defaults enum member, analoguous to TCPListenOptions and StreamListenOptions. It makes sense to have this as an additive option in terms of consistency, but switching default values in multiple places doesn't seem to be a good long-term idea either.

@rracariu rracariu force-pushed the rracariu:patch-1 branch from ae41fc7 to ad66321 May 7, 2019
@rracariu rracariu force-pushed the rracariu:patch-1 branch from ad66321 to 732a570 May 7, 2019
@s-ludwig s-ludwig added the auto-merge label May 19, 2019
@dlang-bot dlang-bot removed the auto-merge label May 19, 2019
@s-ludwig s-ludwig added the auto-merge label May 19, 2019
@s-ludwig s-ludwig merged commit ade7d0c into vibe-d:master May 19, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.