Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wss/ws websocket connection fix #2320 #2321

Merged
merged 1 commit into from Jun 15, 2019

Conversation

@WebFreak001
Copy link
Contributor

commented Jun 7, 2019

connectWebSocket now supports both wss/ws and https/http
the connectWebSocket example is fixed by this and existing usage should work again

connectWebSocket now supports both wss/ws and https/http
the connectWebSocket example is fixed by this and existing usage should
work again
@WebFreak001

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

can we get a stable release including this change (0.8.6) then? Maybe just go back to 0.8.5 and create a branch with just this change and tag that 0.8.6 because this is pretty severe.

The example in the documentation of connectWebSocket also shows to use wss/ws and not https/http so I would imagine all existing connectWebSocket code uses wss/ws

@s-ludwig s-ludwig added the auto-merge label Jun 15, 2019
@dlang-bot dlang-bot merged commit 0b434ca into vibe-d:master Jun 15, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 36.067%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.