Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unlock ConnectionPool on failure #2340

Merged
merged 1 commit into from Jul 31, 2019
Merged

Conversation

tchaloupka
Copy link
Contributor

@tchaloupka tchaloupka commented Jul 31, 2019

I've found that when the connectionFactory method throws, ConnectionPool keeps the lock.
My problem was with dpq2 postgresql connection that can throw ie when it fails to connect to the server.

I'll create PR also to vibe-core.

@s-ludwig s-ludwig merged commit 946d960 into vibe-d:master Jul 31, 2019
3 checks passed
@tchaloupka tchaloupka deleted the connpool_unlockOnErr branch Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants