Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup HTTP client timeout #2347

Merged
merged 3 commits into from Aug 13, 2019

Conversation

@s-ludwig
Copy link
Member

commented Aug 11, 2019

See #2344

@s-ludwig

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2019

Note that the wrong timeout handling in the libasync driver didn't seem to be fixable without making changes in the libasync API, which is currently out of my scope.

@s-ludwig s-ludwig force-pushed the fixup_http_client_timeout branch from 3603f26 to 375b802 Aug 11, 2019
@s-ludwig s-ludwig merged commit 3d46cda into master Aug 13, 2019
3 checks passed
3 checks passed
codecov/patch 42.857% of diff hit (target 31.951%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@s-ludwig s-ludwig deleted the fixup_http_client_timeout branch Aug 13, 2019
@Geod24

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Thanks! Do you have plans for a release any time soon ?

@s-ludwig

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

In fact I wanted to have one out weeks ago, but always get distracted by internal stuff. I would try to make a quick pass over the list of open PRs to see if anything is easy to merge and can then tag an RC.

@denizzzka

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

I would try to make a quick pass over the list of open PRs to see if anything is easy to merge and can then tag an RC.

#2346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.