Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure connection is closed after websocket reader exits #2364

Merged
merged 1 commit into from Dec 5, 2019

Conversation

BenjaminSchaaf
Copy link
Contributor

@BenjaminSchaaf BenjaminSchaaf commented Sep 5, 2019

If a return or throw is triggered in startReader it's possible for the connection to stay open after the scope(exit) call. This could mean that waitForData never returns.

If a `return` or `throw` is triggered in `startReader` it's possible for the connection to stay open after the `scope(exit)` call. This could mean that `waitForData` never returns.
@s-ludwig s-ludwig merged commit 2645c7b into vibe-d:master Dec 5, 2019
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants