Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Mark vibe.crypto.passwordhash as deprecated #2365

Merged
merged 1 commit into from Dec 5, 2019

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented Sep 9, 2019

Remove deprecated passwordhash module, it's insecure.
vibe.crypto.passwordhash is not secure, so mark this as deprecated.
And all functions in this module were already marked as deprecated, so just remove.

@Geod24
Copy link
Contributor

Geod24 commented Sep 10, 2019

Hum, why was the module not deprecated ? I agree with removing the functions, but it could break packages with lingering imports.

@kubo39
Copy link
Contributor Author

kubo39 commented Sep 10, 2019

why was the module not deprecated?

I'm not sure, I saw this issue but didn't mention for it.

Would it be better to mark the passwordhash module as deprecated and remove all functions in this module?

@Geod24
Copy link
Contributor

Geod24 commented Sep 10, 2019

Would it be better to mark the passwordhash module as deprecated and remove all functions in this module?

Yes

@kubo39 kubo39 changed the title Remove vibe.crypto.passwordhash Mark vibe.crypto.passwordhash as deprecated Sep 10, 2019
crypto/vibe/crypto/passwordhash.d Outdated Show resolved Hide resolved
vibe.crypto.passwordhash is not secure and useless(see vibe-d#794), so mark
this module as deprecated.
And All functions in this module were already marked as deprecated,
so remove it.
@kubo39 kubo39 changed the title Mark vibe.crypto.passwordhash as deprecated [WIP] Mark vibe.crypto.passwordhash as deprecated Sep 13, 2019
@dlang-bot dlang-bot added the WIP label Sep 13, 2019
@s-ludwig s-ludwig merged commit 0fe69fa into vibe-d:master Dec 5, 2019
3 checks passed
@kubo39 kubo39 deleted the remove-passwordhash branch Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants