Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustment #2384

Merged
merged 2 commits into from Nov 2, 2019
Merged

Minor adjustment #2384

merged 2 commits into from Nov 2, 2019

Conversation

Beyarz
Copy link
Contributor

@Beyarz Beyarz commented Oct 27, 2019

The type attribute is only useful when it's not javascript

The type attribute is only useful when it's not javascript
@s-ludwig
Copy link
Member

s-ludwig commented Nov 2, 2019

I'm not entirely sure how to go about this. It is technically required for HTML 3.x/4.x, but I have no idea how many people still declare their HTML documents like that these days (and additionally using this filter). Unfortunately it is not possible to know which version is used from within the filter.

@Beyarz
Copy link
Contributor Author

Beyarz commented Nov 2, 2019

I'm not entirely sure how to go about this. It is technically required for HTML 3.x/4.x, but I have no idea how many people still declare their HTML documents like that these days (and additionally using this filter). Unfortunately it is not possible to know which version is used from within the filter.

Should we just leave it as it is?

Removed type from style tag
@Beyarz
Copy link
Contributor Author

Beyarz commented Nov 2, 2019

While I am at it, the type attribute for the style tag is optional too.

@Beyarz
Copy link
Contributor Author

Beyarz commented Nov 2, 2019

Of course if you want to support the older browsers then I can close my PR.

@s-ludwig
Copy link
Member

s-ludwig commented Nov 2, 2019

Okay, I just tested it and indeed it doesn't matter in practice whether the attribute is there or not for older HTML doctypes on any of the current browser engines. So let's just go ahead with this.

@s-ludwig s-ludwig merged commit fa079e4 into vibe-d:master Nov 2, 2019
3 checks passed
@Beyarz
Copy link
Contributor Author

Beyarz commented Nov 2, 2019

Sweet!

@Beyarz Beyarz deleted the patch-1 branch Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants