Improve OpenSSL version detection #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current way to detect OpenSSL silently fails on Mac OSX. It is also quite crude, relying on the openssl binary. Using a pkg-config approach first, we can support lib-only packages, as well as provide a much better experience to most Mac users.
This was referenced Dec 19, 2019
s-ludwig
approved these changes
Dec 19, 2019
s-ludwig
added a commit
that referenced
this pull request
Jun 7, 2020
This got previously reverted by #2401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Tested on our end, works perfectly: https://travis-ci.com/bpfkorea/agora/jobs/268822369