Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2438 - Error on registerWebInterface with a parameterized constructor class #2439

Merged
merged 1 commit into from May 24, 2020

Conversation

Geod24
Copy link
Contributor

@Geod24 Geod24 commented May 1, 2020

No description provided.

@Geod24
Copy link
Contributor Author

Geod24 commented May 1, 2020

CC @s-ludwig you might want to consider a new release.

web/vibe/web/web.d Outdated Show resolved Hide resolved
Copy link
Contributor

@schveiguy schveiguy left a comment

Looks good. Now I need to do this for parameter serialization too ;)

@Geod24
Copy link
Contributor Author

Geod24 commented May 6, 2020

Ping @s-ludwig , this is blocking quite a few project (including the dlang tour)

@Geod24
Copy link
Contributor Author

Geod24 commented May 9, 2020

Ping @s-ludwig

2 similar comments
@Geod24
Copy link
Contributor Author

Geod24 commented May 18, 2020

Ping @s-ludwig

@o3o
Copy link

o3o commented May 20, 2020

Ping @s-ludwig

web/vibe/web/web.d Outdated Show resolved Hide resolved
@s-ludwig
Copy link
Member

s-ludwig commented May 23, 2020

It's just unfortunate that this apparently triggers an Optlink crash. I couldn't reproduce it locally, so finding a workaround may be a bit involved.

If this weren't the default compilation mode for DMD, I'd just completely remove support for it, instead, but I'm reluctant to raise the bar for beginners. Not yet sure how to go about it.

@wilzbach
Copy link
Member

wilzbach commented May 23, 2020

Dub defaults to mscoff since about a year, so I would recommend to just drop support for Optlink:

https://dlang.org/changelog/2.086.0.html#dmd-mscoff-default

@s-ludwig
Copy link
Member

s-ludwig commented May 24, 2020

Oh, right, I totally forgot about that. Okay, I'll merge then and make the Optlink builds "allowed_failures".

@s-ludwig s-ludwig merged commit 09d48f4 into vibe-d:master May 24, 2020
1 of 2 checks passed
@Geod24 Geod24 deleted the fix-regression branch May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants