Allow const parameters in REST generator

[omerfirmak]

This also allows in parameters to be used with
--preview=in.

[Geod24]

Casting const away is not the right approach. Rather, mutability should not be required.
To do this, the value have to be constructed in one go, not piece-meal. That's for example why our deserializer does this:
https://github.com/bosagora/serialization/blob/8f1e4c124e7c909e7b65ffea39e996fc116ba181/source/agora/serialization/Serializer.d#L691-L699

The staticMap means we end up calling the constructor, and give it function calls as parameter.
Another "nice" trick is how we deal with static arrays: https://github.com/bosagora/serialization/blob/8f1e4c124e7c909e7b65ffea39e996fc116ba181/source/agora/serialization/Serializer.d#L609-L617

Nowhere in the serializer do we have away constness (we do have cast, but they never remove const). While casting away constness is sometimes okay, modifying the underlying data (which this does) never is.

[omerfirmak]

Updated

[Geod24]

Test plz

[omerfirmak]

Test plz

Added

[Geod24]

web-framework-i18n-example ~master: building configuration "application"...
Compiling Diet HTML template home.dt...
../../web/vibe/web/i18n.d(222,4): Error: `"Missing translation key for en_US; home: This is the internationalization example app."`
../../web/vibe/web/i18n.d(175,24):        called from here: `tr(key, null, 0, context)`
../../web/vibe/web/web.d(340,99):        called from here: `tr(key, context)`
/home/runner/.dub/packages/diet-ng-1.8.0/diet-ng/source/diet/traits.d(75,23):        called from here: `translate(text, context)`
/home/runner/.dub/packages/diet-ng-1.8.0/diet-ng/source/diet/parser.d(1239,17):        called from here: `translate(kln, stripExtension(baseName(loc.file)))`
/home/runner/.dub/packages/diet-ng-1.8.0/diet-ng/source/diet/parser.d(1110,20):        called from here: `parseTextLine(remainder, ret, tmploc)`
/home/runner/.dub/packages/diet-ng-1.8.0/diet-ng/source/diet/parser.d(1044,38):        called from here: `parseTagLine(input, loc, has_nested)`
/home/runner/.dub/packages/diet-ng-1.8.0/diet-ng/source/diet/parser.d(77,76):        called from here: `parseDietRaw(f)`

@s-ludwig : Looks like our CI is broken ?

[Geod24]

Indeed, it's also triggering in Buildkite: dlang/dmd#12526 (comment)

[PetarKirov]

@Geod24 I think the cause may have been this PR: rejectedsoftware/diet-ng#92

[Geod24]

@omerfirmak : Please rebase

[omerfirmak]

Rebased

[Geod24]

[INFO] Running test rest
+ cd tests/rest
+ dub --compiler=dmd --build-mode=separate
Running pre-generate commands for vibe-d:tls...
Performing "debug" build using dmd for x86_64.
[...]
tests ~master: building configuration "application"...
../../web/vibe/web/rest.d(1609,6): Error: static assert:  `sroute.parameters[0].kind == ParameterKind.header` is false
../../web/vibe/web/rest.d(442,45):        instantiated from here: `jsonMethodHandler!(constRefFoo, 1LU, Example8)`
source/app.d(721,23):        instantiated from here: `registerRestInterface!(Example8)`
dmd failed with exit code 1.

[omerfirmak]

What, dlang/dmd@2333339 should've fixed it.

[Geod24]

dlang/dmd@03c3060

Only for v2.096.1 and above (LDC 1.26). So you need to version out the test for anything less than that (we test with 10 versions of DMD). But it also fails on dmd-latest so no luck here.

[omerfirmak]

Let's see if this will help. Works fine on LDC 1.27.0.

[Geod24]

Hold on, we use inIn for "input parameter", not the in storage class, right ? Damn that's confusing :D