Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for InputStreamProxy REST return type #2602

Merged
merged 1 commit into from Sep 1, 2021

Conversation

s-ludwig
Copy link
Member

@s-ludwig s-ludwig commented Sep 1, 2021

Allows to process large response bodies without loading everything into RAM.

Allows to process large response bodies without loading everything into RAM.
@Geod24
Copy link
Contributor

Geod24 commented Sep 1, 2021

Any chance that we could recognize https://dlang.org/phobos/std_range_interfaces.html too ?
I've been wanting to return ranges from my interfaces since forever.

@s-ludwig
Copy link
Member Author

s-ludwig commented Sep 1, 2021

@Geod24: That should be relatively easy with a wrapped StreamInputRange and also seems to me like a reasonable extension. I'd just leave that for a separate PR.

Copy link
Contributor

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly straightforward, LGTM

@Geod24 Geod24 merged commit 3ac9f7b into master Sep 1, 2021
@Geod24 Geod24 deleted the rest_inputstream_return branch September 1, 2021 09:08
@s-ludwig
Copy link
Member Author

s-ludwig commented Sep 2, 2021

@Geod24: I've briefly started to implement InputRange support, but I'd defer that to the next release, because there are too many questions w.r.t. handling complex range element types (in the form of stream based serialization support). We should first discuss a possible approach as part of #2324.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants