Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

300 hecto-nanoseconds is too strict #2613

Merged
merged 1 commit into from Sep 29, 2021
Merged

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented Sep 29, 2021

This commit changes digest auth timeout interval: 5 minutes.

@Geod24
Copy link
Contributor

Geod24 commented Sep 29, 2021

I think it'd be better to either:

  • Make timeout a Duration;
  • Make the code using timeout call .seconds, as it seems to be the intended resolution;

Instead of storing hnsecs in timeout, which would be surprising to most people IMO.

This commit changes digest auth timeout interval: 5 minutes.
@Geod24
Copy link
Contributor

Geod24 commented Sep 29, 2021

Since this is (technically) a breaking change, paging @s-ludwig .
I think it's one of those changes that make sense (considering the class is broken to the point of being unusable in a real-world scenario IIRC) so IMO it's acceptable.

@s-ludwig
Copy link
Member

Agreed, makes sense especially because obviously nobody has used or could use digest auth productively.

@Geod24 Geod24 merged commit fe7f00b into vibe-d:master Sep 29, 2021
@kubo39 kubo39 deleted the timeout300seconds branch September 29, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants