Register default port for common internet schema #2622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates default port from
URL
and ties default port to common internet schema. Default behavior ofURL.defaultPort
is kept (returns 0 for unknown schemas). Built-in schemas are registered at init.Changes
StringSet
renamed and converted toushort[string]
mapDecision points before merge
registerCommonInternetSchema
can throw exception when schema is already registered within built-in schemas (or user schemas, user schemas can be updated silently) -> Schemas will be updated silently✅getDefaultPortOfCommonInternetSchema
can benothrow
(thus@nogc
) and return 0 directly