Normalization capability for URL #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
requested changes
Nov 5, 2021
inet/vibe/inet/url.d
Outdated
|
|
||
| Params: | ||
| isDirectory = Path of the URL represents a directory, a trailing | ||
| slash is added when true |
There was a problem hiding this comment.
"a trailing slash is added when true"
Two things:
- "if one is not already present, a trailing slash will be appended when
true" - What happens if this is false but there is a trailing slash ?
There was a problem hiding this comment.
Trailing slash is never removed nor added when this is false (except when path is empty it is added)
|
The dependent PR has been merged, this can be rebased. |
Geod24
reviewed
Nov 5, 2021
Geod24
reviewed
Nov 5, 2021
Geod24
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2626 due to an unittest, dependency can be removed easily.
URL normalization without semantic changes capability is added
normalizemethod is addednormalizedmethod is added