Fix OpenSSL version check for 3.x.x

[s-ludwig]

See #2647

[s-ludwig]

@dd86k, can you test if this fixes the build on your machine?

[dd86k]

Hi @s-ludwig

After cloning 0.9.4+commit.56.g86e94971 (from master) and having it added to dub with add-local, does not seem to work. Do say if I'm doing it wrong.

Here's the output I get under my Ubuntu 22.04 LTS VM (libssl-dev is at version 3.0.2-0ubuntu1.1):

output.log

[s-ludwig]

Thanks for trying it out! It looks like the dub add-local part has worked as expected, but it seems like that particular commit doesn't contain the changes here. I couldn't find the commit g86e94971, so I guess that could be a merge commit generated by a git pull? Can you try again with git checkout fix_openssl_3_version_check, or use https://github.com/vibe-d/vibe.d/archive/939b13cd5244d7ac4f52e238d925ca1a6c3de00c.zip directly?

[dd86k]

Oh, my bad, forgot to checkout to fix_openssl_3_version_check, the description is now at vibe-d-0.9.4+commit.57.g939b13cd.

Here is the new output (I get the same results using ldc2):

output-dmd.log

Hope this is more helpful.

[s-ludwig]

I've added some 3.x specific wrappers. If this doesn't work, I'll look into officially adding 3.x as a CI test.

[dd86k]

ERR_raise seems to be the only undefined reference left:

/usr/bin/ld: /tmp/.dub/build/vibe-d-0.9.4+commit.58.g7349013a/openssl-debug-linux.posix-x86_64-dmd_v2.099.1-530F7268A1390F57959C8EAB656E0DF5/libvibe-d_tls.a(openssl_1d3_448.o): in function `_D4vibe6stream7openssl11setSSLErrorFNbNeAyaQdiQgZv':
/home/dd/dev/vibe-test/../vibe.d/tls/vibe/stream/openssl.d:1411: undefined reference to `ERR_raise'
collect2: error: ld returned 1 exit status
Error: linker exited with status 1
/usr/bin/dmd failed with exit code 1.

[s-ludwig]

Okay, ERR_raise is actuallyERR_raise_data under the surface, pushed another fix.

[Geod24]

Tested locally:

tls/vibe/stream/openssl.d(299,45): Error: no property `GEN_DNS` for type `deimos.openssl.x509v3.GENERAL_NAME_st`
tls/vibe/stream/openssl.d(318,46): Error: no property `GEN_IPADD` for type `deimos.openssl.x509v3.GENERAL_NAME_st`
tls/vibe/stream/openssl.d(1173,8): Error: no property `GEN_DNS` for type `deimos.openssl.x509v3.GENERAL_NAME_st`
tls/vibe/stream/openssl.d(1178,8): Error: no property `GEN_IPADD` for type `deimos.openssl.x509v3.GENERAL_NAME_st`
tls/vibe/stream/openssl.d(1186,33): Error: function `deimos.openssl.x509v3.GENERAL_NAMES_free(stack_st_GENERAL_NAME* a)` is not callable using argument types `(STACK_OF!(GENERAL_NAME_st)*)`
tls/vibe/stream/openssl.d(1186,33):        cannot pass argument `gens` of type `STACK_OF!(GENERAL_NAME_st)*` to parameter `stack_st_GENERAL_NAME* a`
tls/vibe/stream/openssl.d(1191,33): Error: no property `GEN_DNS` for type `deimos.openssl.x509v3.GENERAL_NAME_st`

Cherry-picking the first commit in #2652 fixes the GEN_{DNS,IPADD} issue. Looking into the last one, might push to your branch @s-ludwig .

[s-ludwig]

Okay, so I've installed an Ubuntu 22.04 VM and tested this successfully now. I couldn't reproduce the GEN_* issues, though, did you maybe force compilation with the Deimos 2.x bindings instead of staying on 1.x?

[Geod24]

I couldn't reproduce [...]

Right, I edited my dub.selections.json to test some changes. Tested locally, LGTM.

[Geod24]

Could you make a new release ?

[s-ludwig]

Let's try to also get the two URL PRs in (or at least #2653 for now), I'll prepare the change log in the meantime.