Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of CachedFileStream and destroy underlying streams on close() #2745

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

s-ludwig
Copy link
Member

Moves all members into the CTX struct that needs to be maintained anyway. This reduces the instance size in order to ensure it fits into an interface proxy. All associated resources are now freed upon calling close().

@s-ludwig s-ludwig requested a review from l-kramer August 26, 2023 12:22
@s-ludwig s-ludwig force-pushed the cached_file_stream_improvement branch from 1139906 to cbf9faa Compare August 26, 2023 12:23
… close().

Moves all members into the `CTX` struct that needs to be maintained anyway. This reduces the instance size in order to ensure it fits into an interface proxy. All associated resources are now freed upon calling close().
@s-ludwig s-ludwig force-pushed the cached_file_stream_improvement branch from cbf9faa to ab27a34 Compare August 26, 2023 13:11
@s-ludwig s-ludwig enabled auto-merge August 26, 2023 13:11
@s-ludwig s-ludwig merged commit aa616d6 into master Aug 26, 2023
@s-ludwig s-ludwig deleted the cached_file_stream_improvement branch August 26, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants