New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide explicit Bson.toString() method. #468

Merged
merged 1 commit into from Jan 17, 2014

Conversation

Projects
None yet
2 participants
@klickverbot
Contributor

klickverbot commented Jan 17, 2014

Otherwise, opDispatch() will be invoked when trying to
writeln() a Bson object for debugging purposes, leading to
a confusing exception.

I'm not sure whether goign through Json is the best idea,
it just seemed like a convenient fix for the time being.

Provide explicit Bson.toString() method.
Otherwise, opDispatch() will be invoked when trying to
writeln() a Bson object for debugging purposes, leading to
a confusing exception.

I'm not sure whether goign through Json is the best idea,
it just seemed like a convenient fix for the time being.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jan 17, 2014

Member

That topic came up a number of times now and I always had to give an example with an explicit .toJson, so this actually makes a lot of sense. I think I was a bit too conservative here with adding methods to Bson. Going through JSON should be totally fine for now, since the output is meant purely for human inspection (no matching fromString).

Member

s-ludwig commented Jan 17, 2014

That topic came up a number of times now and I always had to give an example with an explicit .toJson, so this actually makes a lot of sense. I think I was a bit too conservative here with adding methods to Bson. Going through JSON should be totally fine for now, since the output is meant purely for human inspection (no matching fromString).

s-ludwig added a commit that referenced this pull request Jan 17, 2014

Merge pull request #468 from klickverbot/bson-tostring
Provide explicit Bson.toString() method.

@s-ludwig s-ludwig merged commit 0089cf6 into vibe-d:master Jan 17, 2014

@klickverbot klickverbot deleted the klickverbot:bson-tostring branch Jan 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment