New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added convenience method for appending to a file... #489

Merged
merged 2 commits into from Feb 2, 2014

Conversation

Projects
None yet
3 participants
@Extrawurst
Contributor

Extrawurst commented Jan 31, 2014

...(just like nodejs's fs.appendFile)

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Jan 31, 2014

Contributor

Doc doesn' say what happens if the file is locked?

Contributor

etcimon commented Jan 31, 2014

Doc doesn' say what happens if the file is locked?

@Extrawurst

This comment has been minimized.

Show comment
Hide comment
@Extrawurst

Extrawurst Jan 31, 2014

Contributor

In the end it simply uses openFile and the docs of that also don't state what happens when the file is locked

Contributor

Extrawurst commented Jan 31, 2014

In the end it simply uses openFile and the docs of that also don't state what happens when the file is locked

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 1, 2014

Member

Agreed, it will throw an exception like almost any other function when an error occurs. I hope that D/Druntime/Phobos will get a standard exception hierarchy at some point not too distant in the future. When that happens, I'll use proper specialized exception types and document everything, but right now I don't want to create an own, incompatible exception hierarchy.

Member

s-ludwig commented Feb 1, 2014

Agreed, it will throw an exception like almost any other function when an error occurs. I hope that D/Druntime/Phobos will get a standard exception hierarchy at some point not too distant in the future. When that happens, I'll use proper specialized exception types and document everything, but right now I don't want to create an own, incompatible exception hierarchy.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 1, 2014

Member

The only change that I'd still make is to call it appendToFile to make it grammatically sound.

Member

s-ludwig commented Feb 1, 2014

The only change that I'd still make is to call it appendToFile to make it grammatically sound.

@Extrawurst

This comment has been minimized.

Show comment
Hide comment
@Extrawurst

Extrawurst Feb 1, 2014

Contributor

done ;)

Contributor

Extrawurst commented Feb 1, 2014

done ;)

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 2, 2014

Member

Thanks!

Member

s-ludwig commented Feb 2, 2014

Thanks!

s-ludwig added a commit that referenced this pull request Feb 2, 2014

Merge pull request #489 from Extrawurst/master
added convenience method for appending to a file...

@s-ludwig s-ludwig merged commit d8550ef into vibe-d:master Feb 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment