New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tests where not working. #541

Merged
merged 1 commit into from Feb 24, 2014

Conversation

Projects
None yet
2 participants
@Geod24
Contributor

Geod24 commented Feb 20, 2014

This fixes the building failure on the tests.
I also added "exitEventLoop(true);" at the end of the tests.
I wonder however what is the purpose of that folder as they were obviously not run.
Shouldn't they be either moved to "examples", or added to travis ?

The tests where not working.
- args/test.sh was out of sync (wrong name provided);
- mongodb and restclient used LogLevel.Debug instead of debug_.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 24, 2014

Member

Yes, those tests haven't been run in a long time and should probably added to Travis (and definitely to our internal CI server) - I'll open a ticket to remember doing that. Thanks for fixing them up.

Member

s-ludwig commented Feb 24, 2014

Yes, those tests haven't been run in a long time and should probably added to Travis (and definitely to our internal CI server) - I'll open a ticket to remember doing that. Thanks for fixing them up.

s-ludwig added a commit that referenced this pull request Feb 24, 2014

@s-ludwig s-ludwig merged commit 9013aaa into vibe-d:master Feb 24, 2014

1 check passed

default The Travis CI build passed
Details

@Geod24 Geod24 deleted the Geod24:fix-unittests branch Feb 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment