New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket should default to strict receive #543

Merged
merged 1 commit into from Feb 24, 2014

Conversation

Projects
None yet
2 participants
@MartinNowak
Contributor

MartinNowak commented Feb 22, 2014

The two methods receiveText and receiveBinary both support a strict flag, to enforce the correct frame opcode.
It's very counterintuitive that the strict flag defaults to false.
http://vibed.org/api/vibe.http.websockets/WebSocket.receiveText

@MartinNowak MartinNowak restored the MartinNowak:fix543 branch Feb 22, 2014

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 24, 2014

Member

I think the reason to keep the default non-strict was that browsers didn't even properly implement the binary message type at the time WebSocket support was implemented and also the standard still wasn't finished. It would be interesting to see how the latest versions of each browser vendor behave today. But considering that the RFC is now finished and most browsers should behave correctly, I agree that it makes more sense to have a strict default.

Member

s-ludwig commented Feb 24, 2014

I think the reason to keep the default non-strict was that browsers didn't even properly implement the binary message type at the time WebSocket support was implemented and also the standard still wasn't finished. It would be interesting to see how the latest versions of each browser vendor behave today. But considering that the RFC is now finished and most browsers should behave correctly, I agree that it makes more sense to have a strict default.

s-ludwig added a commit that referenced this pull request Feb 24, 2014

Merge pull request #543 from MartinNowak/fix543
WebSocket should default to strict receive

@s-ludwig s-ludwig merged commit fc34e61 into vibe-d:master Feb 24, 2014

1 check passed

default The Travis CI build passed
Details

@MartinNowak MartinNowak deleted the MartinNowak:fix543 branch Feb 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment