New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken keepAlive timeout #597

Merged
merged 1 commit into from Mar 26, 2014

Conversation

Projects
None yet
2 participants
@Extrawurst
Contributor

Extrawurst commented Mar 26, 2014

problem with calling empty is that the libevent driver implementation of empty checks leastSize and leastSize is blocking without a timeout. this in turn renders the keepAlive timeout useless.

fix broken keepAlive timeout
problem with calling `empty` is that in the libevent driver implementation of `empty` checks `leastSize` and `leastSize` is blocking without a timeout. this in turn renders the keepAlive timeout useless.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 26, 2014

Member

Good catch. I'll change it a bit further, so that the log message is also correct if the client disconnects during the waitForData period.

Member

s-ludwig commented Mar 26, 2014

Good catch. I'll change it a bit further, so that the log message is also correct if the client disconnects during the waitForData period.

s-ludwig added a commit that referenced this pull request Mar 26, 2014

Merge pull request #597 from Extrawurst/patch-1
fix broken keepAlive timeout

@s-ludwig s-ludwig merged commit 3214223 into vibe-d:master Mar 26, 2014

@Extrawurst Extrawurst deleted the Extrawurst:patch-1 branch Mar 26, 2014

s-ludwig added a commit that referenced this pull request Mar 26, 2014

Move the client disconnect message in the HTTP server after the waitF…
…orData call. See #597.

Previously, the log message would indicate that a connection timed out, even if the client actively disconnected during the keep-alive period.
@Extrawurst

This comment has been minimized.

Show comment
Hide comment
@Extrawurst

Extrawurst Mar 26, 2014

Contributor

this btw. was the reason our vserver got stuck with too many open tcp sockets the other day. darn android does not close those tcp connections when the app that issued them goes to background. so every player had such an open tcp connection to us even when they were not playing for hours because the keepAlive timeout did not step in ^^
i am all for another RC-tag

Contributor

Extrawurst commented Mar 26, 2014

this btw. was the reason our vserver got stuck with too many open tcp sockets the other day. darn android does not close those tcp connections when the app that issued them goes to background. so every player had such an open tcp connection to us even when they were not playing for hours because the keepAlive timeout did not step in ^^
i am all for another RC-tag

@Extrawurst

This comment has been minimized.

Show comment
Hide comment
@Extrawurst

Extrawurst Mar 26, 2014

Contributor

@s-ludwig or what is the roadmap for the .19 release ?

Contributor

Extrawurst commented Mar 26, 2014

@s-ludwig or what is the roadmap for the .19 release ?

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 26, 2014

Member

Still just waiting for #560. I'll continue the work tomorrow if Etienne is still busy with other things. I'll make another RC tag then, too. I think another week of testing and then 0.7.19 should finally be pushed out.

Member

s-ludwig commented Mar 26, 2014

Still just waiting for #560. I'll continue the work tomorrow if Etienne is still busy with other things. I'll make another RC tag then, too. I think another week of testing and then 0.7.19 should finally be pushed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment