New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion when requesting URL containing ':' from serveStaticFiles. #694

Merged
merged 1 commit into from Jun 19, 2014

Conversation

Projects
None yet
2 participants
@klickverbot
Contributor

klickverbot commented Jun 19, 2014

Paths containing a colon were considered to be Windows absolute
paths, causing Path.opBinary!("~") to assert. Now, the request is
just ignored (causing a 404 to be gennerated).

Fix assertion when requesting URL containing ':' from serveStaticFiles.
Paths containing a colon were considered to be Windows absolute
paths, causing Path.opBinary!("~") to assert. Now, the request is
just ignored (causing a 404 to be gennerated).

s-ludwig added a commit that referenced this pull request Jun 19, 2014

Merge pull request #694 from klickverbot/url-colon-crash
Fix assertion when requesting URL containing ':' from serveStaticFiles.

@s-ludwig s-ludwig merged commit e9365ca into vibe-d:master Jun 19, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@klickverbot klickverbot deleted the klickverbot:url-colon-crash branch Jun 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment