New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiline response support #746

Merged
merged 1 commit into from Jul 28, 2014

Conversation

Projects
None yet
2 participants
@etcimon
Contributor

etcimon commented Jul 28, 2014

Follow-up of #742

Here is the debug info before:

[BCEC0081:BCED3181 2014.07.27 20:57:57.769 dbg] Web handler postContactForm has thrown: std.conv.ConvException@/usr/share/src/phobos/std/conv.d(1689): Unexpected '-' when converting from type string to type int
[BCEC0081:BCED3181 2014.07.27 20:57:57.769 dbg] ----------------
[BCEC0081:BCED3181 2014.07.27 20:57:57.769 dbg] ./app(pure @safe int std.conv.to!(int).to!(immutable(char)[]).to(immutable(char)[])+0x20) [0x70c5b4]
[BCEC0081:BCED3181 2014.07.27 20:57:57.769 dbg] ./app(void vibe.mail.smtp.expectStatus(vibe.core.stream.InputStream, int, immutable(char)[])+0xbc) [0x7da798]

After:

[230D30E5:230E61E5 2014.07.28 15:28:25.885 dbg] EHLO response: 250-www.domain.com Hello localhost [127.0.0.1]
[230D30E5:230E61E5 2014.07.28 15:28:25.885 dbg] EHLO response: 250-SIZE 52428800
[230D30E5:230E61E5 2014.07.28 15:28:25.885 dbg] EHLO response: 250-8BITMIME
[230D30E5:230E61E5 2014.07.28 15:28:25.885 dbg] EHLO response: 250-PIPELINING
[230D30E5:230E61E5 2014.07.28 15:28:25.885 dbg] EHLO response: 250-AUTH PLAIN LOGIN
[230D30E5:230E61E5 2014.07.28 15:28:25.885 dbg] EHLO response: 250-STARTTLS
[230D30E5:230E61E5 2014.07.28 15:28:25.885 dbg] EHLO response: 250 HELP
[230D30E5:230E61E5 2014.07.28 15:28:25.885 dbg] seding auth
[230D30E5:230E61E5 2014.07.28 15:28:25.886 dbg] seding auth info
[230D30E5:230E61E5 2014.07.28 15:28:25.927 dbg] authed

This is with dovecot, which is de facto on many servers. I think gmail also communicates this way,

openssl s_client -connect smtp.gmail.com:465 -crlf -ign_eof
[... lots of openssl output ...]
220 mx.google.com ESMTP m46sm11546481eeh.9
EHLO localhost
250-mx.google.com at your service, [1.2.3.4]
250-SIZE 35882577
250-8BITMIME
250-AUTH LOGIN PLAIN XOAUTH
250 ENHANCEDSTATUSCODES
AUTH PLAIN AG5pY2UudHJ5QGdtYWlsLmNvbQBub2l0c25vdG15cGFzc3dvcmQ=
235 2.7.0 Accepted
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 28, 2014

Member

Thanks!

BTW, best way to mark the original issue as fixed is to include Fixes #742 in the commit message, to that it gets automatically closed once it gets merged. It's also possible to convert a normal issue into a pull request, but I didn't do that myself.

Member

s-ludwig commented Jul 28, 2014

Thanks!

BTW, best way to mark the original issue as fixed is to include Fixes #742 in the commit message, to that it gets automatically closed once it gets merged. It's also possible to convert a normal issue into a pull request, but I didn't do that myself.

s-ludwig added a commit that referenced this pull request Jul 28, 2014

Merge pull request #746 from etcimon/smtp-fix
Added multiline response support. Fixes #742.

@s-ludwig s-ludwig merged commit 8e53208 into vibe-d:master Jul 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Jul 28, 2014

Contributor

best way to mark the original issue as fixed is to include Fixes #742 in the commit message

Very good to know, thanks for the tip!

Contributor

etcimon commented Jul 28, 2014

best way to mark the original issue as fixed is to include Fixes #742 in the commit message

Very good to know, thanks for the tip!

@etcimon etcimon deleted the etcimon:smtp-fix branch Jul 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment