New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ubyte[] as a redis reply type #761

Merged
merged 1 commit into from Aug 3, 2014

Conversation

Projects
None yet
2 participants
@sinkuu
Contributor

sinkuu commented Aug 3, 2014

ubyte arrays can be stored, but cannot be taken from a database directly.

ubyte[] arr = [0, 1, 2, 3, 4, 5];
db.set("key", arr); // ok

auto ret = db.get!(ubyte[])("key"); // Unsupported Redis reply type
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 3, 2014

Member

Interesting, I made exactly the same fix yesterday, but didn't push it yet ;) I'll use yours and then start to convert RedisReply into a proper D range. The next planned direction is to reduce the need to memory allocations further by extending the API a bit.

Member

s-ludwig commented Aug 3, 2014

Interesting, I made exactly the same fix yesterday, but didn't push it yet ;) I'll use yours and then start to convert RedisReply into a proper D range. The next planned direction is to reduce the need to memory allocations further by extending the API a bit.

s-ludwig added a commit that referenced this pull request Aug 3, 2014

Merge pull request #761 from sinkuu/add_replytype
Support ubyte[] as a redis reply type.

@s-ludwig s-ludwig merged commit 61f9568 into vibe-d:master Aug 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@sinkuu

This comment has been minimized.

Show comment
Hide comment
@sinkuu

sinkuu Aug 3, 2014

Contributor

Thanks.

Interesting, I made exactly the same fix yesterday,

Wow!

I'll use yours and then start to convert RedisReply into a proper D range. The next planned direction is to reduce the need to memory allocations further by extending the API a bit.

Awesome, I wondered why it isn't a Range.

Contributor

sinkuu commented Aug 3, 2014

Thanks.

Interesting, I made exactly the same fix yesterday,

Wow!

I'll use yours and then start to convert RedisReply into a proper D range. The next planned direction is to reduce the need to memory allocations further by extending the API a bit.

Awesome, I wondered why it isn't a Range.

@sinkuu sinkuu deleted the sinkuu:add_replytype branch Aug 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment