New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed compile error #783

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@lindt
Contributor

lindt commented Aug 14, 2014

could you please merge this. template has been faulty.
template, so compiler does not complain, because it's never instantiated. sorry for not adding a test.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 15, 2014

Member

From what I gather, this will yield a different command format, because using ARGS directly in the CMD struct really will actually result in multiple fields, which will be serialized one by one instead of as one array as the original code seemed to intend. The correct fix in that case should be to simply rename Pipeline to Nodes. Did you test with your changes?

Member

s-ludwig commented Aug 15, 2014

From what I gather, this will yield a different command format, because using ARGS directly in the CMD struct really will actually result in multiple fields, which will be serialized one by one instead of as one array as the original code seemed to intend. The correct fix in that case should be to simply rename Pipeline to Nodes. Did you test with your changes?

@lindt

This comment has been minimized.

Show comment
Hide comment
@lindt

lindt Aug 15, 2014

Contributor

Tried the Pipeline to Nodes change first, but couldn't find out a way to use it. If passing ARGS as Bson[] in this version, then the mongo server just will return an "Aggregate command failed".

Using and testing it in the version above, but passing ARGS as Bson[] which probably was not the intended way.

Sönke, thanks for your fast reply.

Contributor

lindt commented Aug 15, 2014

Tried the Pipeline to Nodes change first, but couldn't find out a way to use it. If passing ARGS as Bson[] in this version, then the mongo server just will return an "Aggregate command failed".

Using and testing it in the version above, but passing ARGS as Bson[] which probably was not the intended way.

Sönke, thanks for your fast reply.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 15, 2014

Member

Okay, that makes sense. In this case it's probably best to keep the Pipeline based code and make a special case for Bson[]. I'll look into that later today and add some examples.

Member

s-ludwig commented Aug 15, 2014

Okay, that makes sense. In this case it's probably best to keep the Pipeline based code and make a special case for Bson[]. I'll look into that later today and add some examples.

@s-ludwig s-ludwig closed this in 1593108 Sep 4, 2014

marcioapm added a commit to marcioapm/vibe.d that referenced this pull request Sep 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment