New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed REST client failing on POST and 201 status code. #806

Merged
merged 1 commit into from Sep 3, 2014

Conversation

Projects
None yet
3 participants
@yglukhov

yglukhov commented Sep 3, 2014

No description provided.

@mihails-strasuns

View changes

Show outdated Hide outdated source/vibe/http/status.d
@yglukhov

This comment has been minimized.

Show comment
Hide comment
@yglukhov

yglukhov Sep 3, 2014

Fixed and squashed.

yglukhov commented Sep 3, 2014

Fixed and squashed.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Sep 3, 2014

Member

Thanks, merging in. In theory this test could be a bit too lax (e.g. when more exotic status codes, such as 207 Multi-Status are returned), but it's definitely less problematic than the current too strict solution and it's unlikely to cause any real issues practice, so it looks good after all.

Member

s-ludwig commented Sep 3, 2014

Thanks, merging in. In theory this test could be a bit too lax (e.g. when more exotic status codes, such as 207 Multi-Status are returned), but it's definitely less problematic than the current too strict solution and it's unlikely to cause any real issues practice, so it looks good after all.

s-ludwig added a commit that referenced this pull request Sep 3, 2014

Merge pull request #806 from yglukhov/rest-status-code-fix
Fixed REST client failing on POST and 201 status code.

@s-ludwig s-ludwig merged commit 9f6add4 into vibe-d:master Sep 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@yglukhov

This comment has been minimized.

Show comment
Hide comment
@yglukhov

yglukhov commented Sep 3, 2014

Thanx!

@yglukhov yglukhov deleted the yglukhov:rest-status-code-fix branch Sep 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment